Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-studio-plugins.obs-pipewire-audio-capture: Fix/obs pipewire audio capture #195024

Merged
merged 1 commit into from
Nov 11, 2022
Merged

obs-studio-plugins.obs-pipewire-audio-capture: Fix/obs pipewire audio capture #195024

merged 1 commit into from
Nov 11, 2022

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Oct 8, 2022

Description of changes

Fix plugin build for new OBS28 release (coming up with #194578 )
Local test recording with x11/pipewire was successful.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SebTM SebTM changed the title obs-pipewire-audio-capture: 2Fix/obs pipewire audio capture obs-pipewire-audio-capture: Fix/obs pipewire audio capture Oct 8, 2022
@ofborg ofborg bot requested a review from Elinvention October 8, 2022 02:37
@SebTM SebTM changed the title obs-pipewire-audio-capture: Fix/obs pipewire audio capture obs-studio-plugins.obs-pipewire-audio-capture: Fix/obs pipewire audio capture Oct 8, 2022
@miangraham
Copy link
Contributor

Result of nixpkgs-review pr 195024 run on x86_64-linux 1

1 package failed to build:
  • obs-studio-plugins.obs-pipewire-audio-capture

@SebTM
Copy link
Contributor Author

SebTM commented Oct 9, 2022

@miangraham Did you build it against the OBS28 PR referenced above?

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work.

@fpletz fpletz merged commit f631204 into NixOS:master Nov 11, 2022
@SebTM SebTM deleted the fix/obs-pipewire-audio-capture branch December 24, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants