Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio-plugins.obs-move-transition: 2.4.3 -> 2.6.4 #195051

Merged
merged 1 commit into from
Nov 11, 2022
Merged

obs-studio-plugins.obs-move-transition: 2.4.3 -> 2.6.4 #195051

merged 1 commit into from
Nov 11, 2022

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Oct 8, 2022 •
edited

Description of changes

Update to latest version, prepare for #194578 (OBS28)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from starcraft66 October 8, 2022 07:55
starcraft66
starcraft66 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@starcraft66 starcraft66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in a position to test atm this but I'll take you word that it builds!

@miangraham
Copy link
Contributor

Result of nixpkgs-review pr 195051 run on x86_64-linux 1

1 package failed to build:
  • obs-studio-plugins.obs-move-transition

@SebTM
Copy link
Contributor Author

SebTM commented Oct 9, 2022 •
edited

@miangraham Did you build it against the OBS28-PR referenced above?

@SebTM SebTM mentioned this pull request Oct 9, 2022
Merged
13 tasks
fpletz
fpletz approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work.

@fpletz fpletz merged commit 805b69a into NixOS:master Nov 11, 2022
@SebTM SebTM deleted the update/obs-move-transition_264 branch December 24, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@starcraft66 starcraft66 starcraft66 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SebTM @miangraham @fpletz @starcraft66 @bobby285271