Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains.gateway: init at 223.6160.27 #195132

Merged
merged 3 commits into from Oct 13, 2022
Merged

Conversation

kouyk
Copy link
Contributor

@kouyk kouyk commented Oct 8, 2022

Description of changes

Add JetBrains Gateway. This has been tested against JetBrains JDK 17 to be working on NixOS unstable. There is also a minor fix in environment variables for the JetBrains Client to launch correctly from any of the JetBrains IDEs including this as well.

I don't have a darwin device to test this, would appreciate if darwin users can try it out as well.

Credits to https://discourse.nixos.org/t/jetbrains-gateway-client-support-on-nixos/18108 on identifying the additional environment variable to be set.

This should supersede the previous PR #148035.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out using IDEA Community against a VM via ssh, I got it to compile a simple Java hello world.

The IDE does throw a lot of exceptions though (example, shows up as a red notification in the bottom right), I don't know if this is our fault for using a bad JDK or an upstream problem.

@kouyk
Copy link
Contributor Author

kouyk commented Oct 12, 2022

The IDE does throw a lot of exceptions though (example, shows up as a red notification in the bottom right), I don't know if this is our fault for using a bad JDK or an upstream problem.

I've mainly been using CLion, while I didn't notice the same issues there are some other problems such as the IDE can't be restarted remotely, plugins don't behave the same way as when running natively etc. The logs don't seem helpful enough to diagnose this issue. I don't have another non nixos system to verify these issues, but I think Gateway is at least usable for now, more importantly other IDEs can also launch a remote instance once the appropriate env var is set.

@ofborg ofborg bot requested a review from raphaelr October 12, 2022 18:18
@Mic92 Mic92 merged commit a3073c4 into NixOS:master Oct 13, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/jetbrains-gateway-client-support-on-nixos/18108/18

@kouyk kouyk deleted the jetbrains-gateway-client branch October 22, 2022 16:14
atishnazir added a commit to cognitive-i/nixpkgs that referenced this pull request Mar 21, 2024
Jetbrains IDEs download the remote client GUI on each invocation.
This client is not patched for Nix and includes its own JDK.  JDK
selection can be overriden through environment variable (to a Nix
patched version).

Previously this was done with `JETBRAINSCLIENT_JDK`, now it should
be done with `JETBRAINS_CLIENT_JDK`.

See previous PR NixOS#195132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants