Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmagent: init at 1.82.0 #195205

Merged
merged 1 commit into from
Oct 18, 2022
Merged

vmagent: init at 1.82.0 #195205

merged 1 commit into from
Oct 18, 2022

Conversation

NULLx76
Copy link
Member

@NULLx76 NULLx76 commented Oct 9, 2022

Description of changes

vmagent is a lightweight program to scrape prometheus exporters and insert the data into victoriametrics.

More information can be found here: https://github.com/VictoriaMetrics/VictoriaMetrics/tree/master/app/vmagent#vmagent

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

maybe @yorickvP and @ivan can review this as they maintain the victoriametrics nixpkg

pkgs/servers/monitoring/vmagent/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/636

nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/vmagent.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants