Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timedoctor: remove broken uninstallable package #195251

Merged
merged 1 commit into from Oct 10, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Oct 9, 2022

The package fails t install as it requires x86_64-linux, but it's dependency requires i686 linux:

$ nix build --no-link -f. timedoctor --show-trace
error: unsupported CPU i686

   … while evaluating the attribute 'version'

   at pkgs/development/compilers/adoptopenjdk-bin/jdk-linux-base.nix:40:3:

       39|
       40|   version = sourcePerArch.${cpuName}.version or (throw "unsupported CPU ${cpuName}");
         |   ^

I only onticed it because it uses xorg.libXaw3d while nothing else does.

Let's remove it.

/cc maintainer @dsalaza4

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The package fails t install as it requires x86_64-linux, but it's
dependency requires i686 linux:

    $ nix build --no-link -f. timedoctor --show-trace
    error: unsupported CPU i686

       … while evaluating the attribute 'version'

       at pkgs/development/compilers/adoptopenjdk-bin/jdk-linux-base.nix:40:3:

           39|
           40|   version = sourcePerArch.${cpuName}.version or (throw "unsupported CPU ${cpuName}");
             |   ^

I only onticed it because it uses `xorg.libXaw3d` while nothing else does.

Let's remove it.
@trofi trofi mentioned this pull request Oct 10, 2022
13 tasks
@bobby285271 bobby285271 merged commit 294961f into NixOS:master Oct 10, 2022
@trofi trofi deleted the timedoctor-removal branch October 10, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants