chromium: 53 -> 54

[NeQuissimus]

Motivation for this change

Update

Things done

Used update.sh

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • OS X
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[mention-bot]

@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @grahamc and @aszlig to be potential reviewers.

[grahamc]

Hrmmm not so simple this time :(

patching file chrome/common/chrome_paths.cc
Hunk #1 succeeded at 69 (offset 1 line).
Hunk #2 succeeded at 266 (offset 1 line).
Hunk #3 succeeded at 274 (offset 1 line).
Hunk #4 succeeded at 317 (offset 1 line).
Hunk #5 succeeded at 352 (offset 1 line).
sed: can't read chrome/chrome_tests.gypi: No such file or directory
builder for ‘/nix/store/ky882cjxnrnvdqggfs2c2px0342ansb1-chromium-55.0.2883.11.drv’ failed with exit code 2

[NeQuissimus]

Oh, I only built stable...

[NeQuissimus]

OK, I need help with this... :D

I don't even see your error when I build chromiumDev. It complains a lot about PepperFlash and I have spent a good amount of time on this and got nowhere...

I get these

/opt/google/chrome-unstable/PepperFlash: Not found in archive
chmod: cannot access 'PepperFlash/libpepflashplayer.so': No such file or directory
unable to read file PepperFlash/manifest.json: No such file or directory

Seemed to me that PepperFlash has been removed but I am not sure how I would go about fixing that. I don't think I understand the nix expressions for Chromium...

[bendlas]

Continuing from #19678, shall we use this PR as a ticket for the chromium transition?

I took @aszlig 's work on porting to GN and tried to get it built: https://github.com/bendlas/nixpkgs/tree/chromium-gn
It compiles, but there is an rpath issue with linking, that I think I've identified as: #19680
If nobody beats me to it, I'll try to create a temporary gcc wrapper for chromium to deal with this until the issue is resolved.

I added a commit to deactivate PepperFlash, but for a complete port we'll probably need distribute NPAPI flash: https://blogs.adobe.com/flashplayer/2016/08/beta-news-flash-player-npapi-for-linux.html

[aszlig]

@bendlas: Chromium has dropped support for the NPAPI a long time ago, so how do you exactly want to port it? Reviving the old (unsandboxed) NPAPI code?

[bendlas]

@aszlig I probably misremembered. Probably because chromium dropped the PPAPI flash from the default plugin package at the same time where Adobe announced plans to keep NPAPI flash updated in the future. Shall we continue to support PPAPI flash, by downloading it directly from Adobe? What's upstream doing?

[aszlig]

@bendlas: Ah, didn't get that in the first place... So the Chrome binary package doesn't include Pepperflash anymore, right? So yes, I'd get the (PPAPI) plugin directly from Adobe then and drop the plugin from the Chromium plugins package (leaving it to only include widevine).

[grahamc]

(bug roundup highlighted this issue again, #19884) What's the status on updating the stable chromium?

[bendlas]

@grahamc almost there, I could get a successful link with the @rspfile fix in nix-shell --pure, for some reason nix-build still doesn't set the rpath correctly. I'm investigating, but chromium builds are painfully slow

[bendlas]

Link issue should be fixed, just running another build.
The issue with pepperflash seems, that google now wants to keep flashplayer updated via chrome://components https://forums.adobe.com/thread/2221587
If this works for NixOS as well, it would be net gain, otherwise, we need to devise a scheme to find out the most recent version of flash, in our update.sh. Adobe's download page doesn't seem very helpful about it.

[aszlig]

@bendlas: I think it's better to completely decouple pepperflash from Chromium, like it has been back then with the NPAPI flash plugin, especially because Flash versions are no longer tied to Chromium versions (okay, to be more exact: I assume they aren't).

[bendlas]

@aszlig if the auto-update via Component Updater works, wouldn't it be better to take advantage of this, to get faster security updates? I grepped GN flags for flash, but didn't find anything to control Component Updater. Let's see, what it does in a finished build, still waiting for that. Got to run in 15 minutes, unfortunately ...

[bendlas]

EDIT: builds and run
EDIT2: huh, even though pepperflash is deactivated, it works in my build You have version 23,0,0,162 installed; doesn't show up in chrome://components/ though. What sorcery is this?

I rebased and squashed everything in master...bendlas:chromium-54

if somebody wants to take care of pepperflash right now, you can do so on top of that branch, otherwise I recommend pushing this w/o pepperflash, for now.

[NeQuissimus]

Where are we at with this?

@bendlas can you send your progress as a PR? We should have a working up-to-date Chromium then, correct?