gnome.nautilus: use the gtk4 FileChooser settings schema (fixes crash-on-start)

[uninsane]

upstream PR for more context: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1013

with the recent nixpkgs bump from GNOME 42 -> 43, we build nautilus with gtk4 (as upstream expects). if the user has nothing else in their environment providing gtk3, then nautilus fails to locate a gtk3 gsettings schema it depends on. i.e.

$ nautilus
(org.gnome.Nautilus): GLib-GIO-ERROR **: Settings schema 'org.gtk.Settings.FileChooser' is not installed

we could solve this on our end by adding gtk3 to gappsWrapperArgs, but this seems like an upstream bug: i believe they mean to use the gtk4 settings schemas instead of the legacy gtk3 ones.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[SuperSandro2000]

@ofborg build gnome.nautilus

[uninsane]

this is merged upstream now. i don't know much about the GNOME release cycle, but i think the fix made it in before the 43.1 cut, meaning the issue this PR addresses should be fixed when we bump nixpkgs 43.0 -> 43.1.

ordinarily i'd close this PR now, but i see it's marked as a 22.11 blocker and i don't know the workflow around that. if it's still open by the time 43.1 is merged into nixpkgs i'll come back and close this after confirming the fix.

[jtojnar]

Nautilus 43.1 will likely release today so it should be fine.

[SuperSandro2000]

So we wanna wait or merge this?

[amaxine]

I think we can afford to wait a little longer, unless 43.1 isn't happening for nautilus at all anymore. GDM never got any minor releases last cycle, so I'm not sure what the situation is.

[jtojnar]

GDM is a bit understaffed. Nautilus maintainers talked about making a release on Matrix so they are probably just fixing last few bugs.

[jtojnar]

Let’s get this in, Nautilus maintainers still want to fix few more crashes before making a release.

[gvolpe]

Has anyone tried these patches? While it doesn't crash, nautilus kind of struggles to start up, it is very slow and it doesn't respect the dark theme, at least on my system.

[jtojnar]

@gvolpe It was tested in GNOME Shell so the environment accidentally contains GTK 3 schemas, preventing this crash from being encountered.

Nautilus 43 switched to libadwaita so the expected way to switch to dark theme is using nix-shell -p glib gsettings-desktop-schemas --run 'XDG_DATA_DIRS=$GSETTINGS_SCHEMAS_PATH gsettings set org.gnome.desktop.interface color-scheme prefer-dark'

I have not encountered any slowness problems.

[gvolpe]

@jtojnar thanks, I was talking about the patches being applied in this PR. I have an overlay with these patches on my system, but I'm experiencing slowness on every operation on Nautilus after updating to this version with gtk4.

[gvolpe]

@jtojnar I understand this may be a Nautilus bug, but it is nearly unusable for me, so I had to revert to the GTK3 version. Leaving this here in case someone else experiences the same issue: gvolpe/nix-config@397c9a8

[jtojnar]

@gvolpe maybe, if you have time, you can jump on https://matrix.to/#/#nautilus:gnome.org and help Nautilus developers debug this. So far, they have not been able to reproduce it.

[gvolpe]

Thanks @jtojnar , I joined the room. I'm thinking it could be because the icon theme I use is based on gtk3, so it may conflict with nautilus' gtk4? And the theme I use only refers to gtk-engine-murrine, but I'm not very familiar with these terms.

[jtojnar]

@gvolpe Icon themes do not really have anything to do with specific versions of GTK. gtk3 is used there for the program for rebuilding the cache but the cache format did not change between GTK 3 and GTK 4 so it should not really matter.

Theme engines are GTK 2 thing so that is not relevant either. In fact, with libadwaita, custom theme will not be used, unless you explicitly force it using GTK_THEME environment variable. But that is really only meant for debugging.

[gvolpe]

Hmm I'm out of ideas then -_-