mlterm: fix mouse keybinding with numlock #19613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RamKromberg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vrthra and @phanimahesh to be potential reviewers. |
|
@RamKromberg could you fetch the patch from upstream rather than add to the repo? |
|
@vrthra upstream moved around some filenames and functions (xwindow/x_shortcut.c -> uitoolkit/ui_shortcut.c) a few commits earlier so I'm afraid it's not a viable option. |
phanimahesh
approved these changes
Oct 17, 2016
| @@ -20,6 +20,8 @@ stdenv.mkDerivation rec { | |||
| harfbuzz fribidi m17n_lib openssl libssh2 | |||
| ]; | |||
|
|
|||
| patches = [ ./x_shortcut.c.patch ]; #fixes numlock in 3.7.2. https://bitbucket.org/arakiken/mlterm/commits/4820d42c7abfe1760a5ea35492c83be469c642b3 | |||
|
|
|||
There was a problem hiding this comment.
If the patch can't be used directly from upstream, maybe add a note here that it has to be removed for next point release?
There was a problem hiding this comment.
seems redundant but I guess it can't hurt.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
a patch for a very annoying bug upstream fixed ( https://bitbucket.org/arakiken/mlterm/commits/4820d42c7abfe1760a5ea35492c83be469c642b3 ) but has yet point release.
tested in stable pulling from both master or stable rebase.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)