New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etebase-server: add option withPostgres #196342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also have an option for the package instead of adding it only in the module?
It could be done in the same way as the withLdap
option with the default being true
.
fc83d45
to
e6b6fee
Compare
@felschr Added a |
[ etebase-server daphne ] | ||
++ optional (cfg.settings.database.engine == "django.db.backends.postgresql") psycopg2 | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this since withPostgres
's default is true
.
But I guess we could also set withPostgres
to false
by default and keep this.
Would be nice to have a third opinion on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you turn this into a single commit? Otherwise, I think it's good to merge.
b6bb209
to
bdb03bc
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Description of changes
On current nixos-unstable branch, the following etebase-server config using postgresql backend
fails with
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes