Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igh-ethercat: init at 1.5 #196556

Closed
wants to merge 1 commit into from
Closed

Conversation

simonkampe
Copy link
Contributor

@simonkampe simonkampe commented Oct 18, 2022

Description of changes

This will add the tools and kernel modules for the IgH Ethernet Master for Linux (https://etherlab.org/en/ethercat/)

# To get both the tools and the modules:

boot.extraModulePackages = [ config.boot.kernelPackages.igh-ethercat-master ];

environment.systemPackages = with pkgs; [
    config.boot.kernelPackages.igh-ethercat-master
  ];

Is this the correct way or should the tools and modules be added separately? The tooling binaries still need the correct kernel headers to build.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@simonkampe
Copy link
Contributor Author

The release model of this seems to be some sort of rolling release, with 1.5.2 being the latest actual release ~9 years ago. I added a timestamp to the version number that will be updated with the commit date of the built release.

@simonkampe
Copy link
Contributor Author

@SuperSandro2000 Do you have time to review this again?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1723

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@stv0g
Copy link
Contributor

stv0g commented Apr 9, 2024

The IgH ethercat master has now been merged via #298581

@stv0g stv0g closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants