Update Solidity compiler to latest version #19697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeQuissimus
reviewed
Oct 20, 2016
| }; | ||
|
|
||
| patchPhase = '' | ||
| echo >commit_hash.txt af6afb0415761b53721f89c7f65064807f41cbd3 |
There was a problem hiding this comment.
a) Is this file really needed?
b) Can you use pkgs.writeTextFile instead?
There was a problem hiding this comment.
a) Without it, I get this error:
CMake Error at cmake/scripts/buildinfo.cmake:52 (message):
Unable to determine commit hash. Either compile from within git repository
or supply a file called commit_hash.txt
b) How would I do that? It needs to be in the source directory while building. I don't know enough about Nix to figure out how to do that. I tried this and it didn't work:
commitHashFile = pkgs.writeText "commit_hash.txt"
"af6afb0415761b53721f89c7f65064807f41cbd3";
There was a problem hiding this comment.
cp ${commitHashFile} commit_hash.txtwould be a solution here. But I don't see the advantage over echo.
There was a problem hiding this comment.
OK, thanks. Still want to use writeText @NeQuissimus?
|
Other than the above, the build LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)