Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker: 1.8.0 -> 1.10.1 (16.09) #19702

Merged
merged 1 commit into from Oct 19, 2016

Conversation

DamienCassou
Copy link
Contributor

Motivation for this change

Contribute to #19678.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@DamienCassou DamienCassou added this to the 16.09 milestone Oct 19, 2016
@DamienCassou DamienCassou changed the title tracker: 1.8.0 -> 1.10.1 tracker: 1.8.0 -> 1.10.1 (16.09) Oct 19, 2016
@grahamc grahamc merged commit 5ae8917 into NixOS:release-16.09 Oct 19, 2016
@grahamc
Copy link
Member

grahamc commented Oct 20, 2016

@DamienCassou should this be applied to master as well?

@DamienCassou
Copy link
Contributor Author

I agree with you @lethalman, this PR was not necessarily a good idea. I did that while doing other stuff and didn't think too much about it. I just answered to #19678. I didn't even test the binary (as you can see in the checkboxes).

What do we do now?

@grahamc
Copy link
Member

grahamc commented Oct 20, 2016

Hey, yeah, we should revert this. I was looking again and think I misinterpreted the bug report. I've verified it hasn't been released to users yet, so I think reverting is A-OK.

grahamc added a commit that referenced this pull request Oct 20, 2016
@lucabrunox
Copy link
Contributor

No problem. Revert :)

On Thursday 20 October 2016, Damien Cassou notifications@github.com wrote:

I agree with you @lethalman https://github.com/lethalman, this PR was
not necessarily a good idea. I did that while doing other stuff and didn't
think too much about it. I just answered to #19678
#19678. I didn't even test the
binary (as you can see in the checkboxes).

What do we do now?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19702 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdWmKZ7575jhu59geXknj3sFJbPMhHiks5q1xTKgaJpZM4KbXfJ
.

NixOS Linux http://nixos.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants