New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initrd-ssh: allow empty hostKeys #197382
initrd-ssh: allow empty hostKeys #197382
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1309 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would in favor of:
- an option
ignoreEmptyHostKeys
- keep the assert and use that flag to override it
- no warning if
ignoreEmptyHostKeys
is explicitly set
But I have no strong opinion on this.
@RaitoBezarius Thanks for your input! I agree that's a better design and just changed this PR to implement your recommendation instead. |
- rebased on master - NixOS/nixpkgs#197382 has been merged.
This allows users to optionally allow empty host keys for initrd sshd. The original assertion seems to originate in the switch from dropbear to openssh about 3 years ago and makes it impossible to use sshd in your initrd without providing keys at build time. This would be useful for people like me who'd like to optionally generate one or provide them via oob mechanisms.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes