Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: fix aarch64 crashes and skip problematic test #198355

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

collares
Copy link
Member

@collares collares commented Oct 28, 2022

Description of changes

After the GAP update in #192548, fixing Sage tests on aarch64 is now doable. I've submitted https://trac.sagemath.org/ticket/34701 upstream, and this PR will apply the upstream change to fix some GC crashes. Moreover, we disable a GLPK-using test which is known to be slow (https://trac.sagemath.org/ticket/34575).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@collares collares marked this pull request as ready for review November 5, 2022 21:26
@collares
Copy link
Member Author

collares commented Nov 5, 2022

Filed the x86_64 random test failure as https://trac.sagemath.org/ticket/34723

@collares
Copy link
Member Author

collares commented Nov 7, 2022

I'm planning on merging this today as part of ZHF. Objections are welcome.

ZHF: #199919

@collares collares merged commit fc9eb96 into NixOS:master Nov 7, 2022
@collares collares deleted the sage-libgap-aarch64 branch January 26, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant