Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tzdata: 2022e -> 2022f #198475

Merged
merged 1 commit into from Oct 30, 2022
Merged

tzdata: 2022e -> 2022f #198475

merged 1 commit into from Oct 30, 2022

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 29, 2022

Description of changes

https://mm.icann.org/pipermail/tz-announce/2022-October/000075.html

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz October 29, 2022 15:48
trofi
trofi suggested changes Oct 29, 2022
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should target staging as tzdata triggers full nixpkgs rebuild. Otherwise LGTM.

@ajs124 ajs124 changed the base branch from master to staging October 29, 2022 22:35
@ajs124
Copy link
Member Author

ajs124 commented Oct 29, 2022 •
edited

right, sorry. If nobody else has any other comment's I'll merge this in the next 24h, because apparently people in Chihuahua, Mexico will already have wrong time, by then 😬

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/662

@ajs124 ajs124 merged commit 3841cbc into NixOS:staging Oct 30, 2022
@ajs124 ajs124 deleted the upd/tzdata branch October 30, 2022 18:34
@github-actions github-actions bot mentioned this pull request Oct 30, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #198698 for staging-22.05.

@tjni tjni mentioned this pull request Oct 31, 2022
Merged
13 tasks
@sternenseemann sternenseemann mentioned this pull request Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi approved these changes

@LunNova LunNova LunNova approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @nixos-discourse @trofi @LunNova