Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alfis: fix build on aarch64-darwin #198941

Merged
merged 1 commit into from Nov 15, 2022
Merged

alfis: fix build on aarch64-darwin #198941

merged 1 commit into from Nov 15, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 1, 2022 •
edited

Description of changes

Boscop/web-view#292 / ZHF: #199919

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 1, 2022
@ofborg ofborg bot requested a review from misuzu November 1, 2022 13:10
@wegank wegank force-pushed the alfis-aarch64-darwin branch 2 times, most recently from 2be7c4e to dd7b8f7 Compare November 10, 2022 11:22
@ofborg ofborg bot requested a review from misuzu November 10, 2022 11:25
@wegank wegank requested a review from JannikGM November 10, 2022 11:37
@ofborg ofborg bot removed the request for review from JannikGM November 13, 2022 22:40
misuzu
misuzu approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@risicle
Copy link
Contributor

risicle commented Nov 15, 2022

nixpkgs-review still happy, aarch64-linux.

@risicle
Copy link
Contributor

risicle commented Nov 15, 2022

@ofborg build alfis alfis-nogui

@risicle risicle merged commit 032b5c1 into NixOS:master Nov 15, 2022
@wegank wegank deleted the alfis-aarch64-darwin branch November 15, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JannikGM JannikGM JannikGM left review comments

@misuzu misuzu misuzu approved these changes

@risicle risicle risicle approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wegank @risicle @misuzu @JannikGM