jami: 20220825.0828.c10f01f -> 20221031.1308.130cc26 #199821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages built:
|
|
Tested it with my account, login with another device, sending/receiving messages, and audio call. Working well so far. |
foo-dogsquared
approved these changes
Nov 9, 2022
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
SuperSandro2000
requested changes
Nov 17, 2022
| @@ -21,17 +21,17 @@ | |||
| , qtsvg | |||
| , qtwebengine | |||
| , qtwebchannel | |||
| , withWebengine ? true | |||
| # https://git.jami.net/savoirfairelinux/jami-client-qt/-/issues/881 | |||
| # , withWebengine ? false | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks! Patch added.
|
@SuperSandro2000 Is this good to merge? |
|
@ofborg build jami-daemon jami-client |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
jami-client-qt is renamed to jami-client. https://git.jami.net/savoirfairelinux/jami-client-qt/-/commit/bf4a8c314f308877841dcfa8c567cdd097c0fbb0
withWebengine option is removed due to an upstream bug. https://git.jami.net/savoirfairelinux/jami-client-qt/-/issues/881
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes