docs: use overrideAttrs instead of overrideDerivation #20001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aneeshusa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thatdocslady, @rvl and @fpletz to be potential reviewers. |
aneeshusa
force-pushed
the
use-overrideAttrs-instead-of-overrideDerivation-in-docs
branch
2 times, most recently
from
bcc07d0
to
2df7eaa
Compare
dezgeg
reviewed
Oct 30, 2016
| <programlisting> | ||
| nixpkgs.config.packageOverrides = pkgs: { | ||
| hello = pkgs.lib.overrideDerivation pkgs.hello (attrs: { | ||
| hello = pkgs.lib.overrideAttrs pkgs.hello (attrs: { |
There was a problem hiding this comment.
This should be:
hello = pkgs.hello.overrideAttrs (oldAttrs: {
separateDebugInfo = true;
});
dezgeg
reviewed
Oct 30, 2016
| ]; | ||
| environment.systemPackages = [ | ||
| (pkgs.lib.overrideAttrs pkgs.emacs (oldAttrs: { | ||
| name = "emacs-25.0-pre"; |
There was a problem hiding this comment.
There is no lib.overrideAttrs, only emacs.overrideAttrs it seems.
aneeshusa
force-pushed
the
use-overrideAttrs-instead-of-overrideDerivation-in-docs
branch
from
2df7eaa
to
309f414
Compare
aneeshusa
force-pushed
the
use-overrideAttrs-instead-of-overrideDerivation-in-docs
branch
from
309f414
to
3d99eea
Compare
vcunat
added a commit
that referenced
this pull request
Nov 5, 2016
|
I just slightly amended one formulation in 559ddae. |
aneeshusa
deleted the
use-overrideAttrs-instead-of-overrideDerivation-in-docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #10721.
cc @vcunat
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Update the docs to use
overrideAttrsinstead ofoverrideDerivation.There are also ~110 other uses of overrideDerivation in actual Nix code, which I will save for separate PR(s).