Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: fix wrapper #20117

Merged
merged 1 commit into from Nov 3, 2016
Merged

qutebrowser: fix wrapper #20117

merged 1 commit into from Nov 3, 2016

Conversation

ericsagnes
Copy link
Contributor

Motivation for this change

Address #20000.

cc @abbradar The reason was that mk-python-derivation.nix is also calling the derivation postFixup resulting in wrapPythonPrograms called 2 times. That change was added in 85a87f5.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ericsagnes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @kirelagin and @ehahn to be potential reviewers.

@abbradar abbradar merged commit 0914796 into NixOS:master Nov 3, 2016
@abbradar
Copy link
Member

abbradar commented Nov 3, 2016

Thank you for looking at this!

@ericsagnes
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants