Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlas: init at 0.9.0 #201531

Closed
wants to merge 1 commit into from
Closed

atlas: init at 0.9.0 #201531

wants to merge 1 commit into from

Conversation

dit7ya
Copy link
Member

@dit7ya dit7ya commented Nov 16, 2022

Description of changes

Resolves #197774.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure on darwin.

pkgs/development/tools/database/atlas/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/database/atlas/default.nix Outdated Show resolved Hide resolved
@zowoq zowoq mentioned this pull request Nov 26, 2022
Copy link
Contributor

@urandom2 urandom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if you want any help with the maintenance; you beat me to submitting this one, as I hit the issues withe proxyVendor and the workspace described in #203039

pkgs/development/tools/database/atlas/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/database/atlas/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/database/atlas/default.nix Outdated Show resolved Hide resolved
@dit7ya dit7ya changed the title atlas: init at 0.8.0 atlas: init at 0.9.0 Feb 9, 2023

src = fetchFromGitHub {
owner = "ariga";
repo = pname;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo = pname; is nice for DRY but creates a binding that goes too far.

See further information about this here: nix-community/nixpkgs-lint#21


nativeCheckInputs = [ git ];

meta = with lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove with lib;

@drupol drupol marked this pull request as draft August 6, 2023 11:57
@marsam marsam mentioned this pull request Aug 27, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package request: atlas - A database toolkit
4 participants