Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claper: init at 1.1.1 #201607

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

claper: init at 1.1.1 #201607

wants to merge 1 commit into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Nov 17, 2022

Hello,

I'm looking for using Claper webapp, sadly, it's not available in nixpkgs yet.

I have started to do something, but It's obviously not working yet.

This PR is to gather some help from the community, and in the end provide Claper in Nix.

Tasks:

  • Initial default.nix file
  • Fetch the source and compile it
  • Deal with npm stuff
  • Make sure we can run the service in NixOS
  • Provide the service module configuration

The documentation to install it is here: https://github.com/ClaperCo/Claper#installation

Further documentation: https://docs.claper.co/configuration.html

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packaging-claperco-claper-software/23307/1

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postgres setup is weird. Why not use the standard way to create databases?

nixos/modules/services/web-apps/claper.nix Outdated Show resolved Hide resolved
SECRET_KEY_BASE = cfg.secret_key_base;
ENDPOINT_HOST = cfg.server.endpoint_host;
ENDPOINT_PORT = cfg.server.endpoint_port;
PORT = cfg.server.port;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use socket authentication

Copy link
Contributor Author

@drupol drupol Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use socket already but Claper requires an URL.

nixos/modules/services/web-apps/claper.nix Outdated Show resolved Hide resolved
Comment on lines +22 to +25
default = "postgres://claper:claper@127.0.0.1:5432/claper";
type = types.str;
description = lib.mdDoc ''
Path to the UNIX domain-socket to communicate with `postgres`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default is not a unix socket path

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 21, 2023
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants