git-team: 1.7.0 -> 1.8.0 #201972
Merged
git-team: 1.7.0 -> 1.8.0 #201972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigengrau
approved these changes
Nov 20, 2022
lockejan
reviewed
Nov 20, 2022
|
|
||
| nativeBuildInputs = [ installShellFiles ]; | ||
| preBuild = '' | ||
| ${go-mockery}/bin/${go-mockery.meta.mainProgram} --dir=src/ --all --keeptree |
There was a problem hiding this comment.
Where did you find the cmd? In git-teams source? I'm just curious 😃
There was a problem hiding this comment.
I found it here except I used the mockery binary directly instead of using Docker.
There was a problem hiding this comment.
Suggested change
| ${go-mockery}/bin/${go-mockery.meta.mainProgram} --dir=src/ --all --keeptree | |
| mockery --dir=src/ --all --keeptree |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
SuperSandro2000
requested changes
Nov 27, 2022
|
|
||
| nativeBuildInputs = [ installShellFiles ]; | ||
| preBuild = '' | ||
| ${go-mockery}/bin/${go-mockery.meta.mainProgram} --dir=src/ --all --keeptree |
There was a problem hiding this comment.
Suggested change
| ${go-mockery}/bin/${go-mockery.meta.mainProgram} --dir=src/ --all --keeptree | |
| mockery --dir=src/ --all --keeptree |
pkgs/applications/version-management/git-and-tools/git-team/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-team/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-team/default.nix
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Schmitt <git@smittie.de>
1 task
|
Successfully created backport PR #203374 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Jan Schmitt git@smittie.de
https://github.com/hekmekk/git-team/blob/main/CHANGELOG.md#180---2022-10-28
https://github.com/hekmekk/git-team/blob/main/CHANGELOG.md#171---2022-10-09
This supersedes #201227.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes