New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak finding gstreamer plugins in $NIX_PROFILES #20207
Conversation
gst-launch and friends are in the "dev" output now.
Suffix the plugin paths from $NIX_PROFILES instead of prefixing them to $GST_PLUGIN_SYSTEM_PATH. If a program has specifically set up its plugin path to some custom/specific version, we don't want plugins from $NIX_PROFILES to mess things up by having higher priority.
Maybe a separate |
Note that the derivation has no |
I put the binaries in As for finding plugins in |
@ttuegel: Good point. But I don't know when I'll have time to move the lookup from the binaries to the libraries. (It's not high priority for me.) How about merging this now and improve things more later? |
I think we should merge as is, so we can backport to stable without risk. |
* gstreamer-1.0: make gst-launch find plugins again gst-launch and friends are in the "dev" output now. * gstreamer-1.0: lower priority on plugins from $NIX_PROFILES Suffix the plugin paths from $NIX_PROFILES instead of prefixing them to $GST_PLUGIN_SYSTEM_PATH. If a program has specifically set up its plugin path to some custom/specific version, we don't want plugins from $NIX_PROFILES to mess things up by having higher priority. (cherry picked from commit b1df5bf) It seems very unlikely to break anything.
OK, picked to 16.09 as well. Still, multiple outputs generally behave differently than intended due to the default nix version not containing some relatively old patches #19761 (comment). When/if that gets fixed, people will no longer get the |
Motivation for this change
Making gst-launch and friends find plugins is a generally useful thing. It used to work but got broken with the multiple-outputs change. This PR fixes it.
Also lower the priority on plugins found in $NIX_PROFILES by using --suffix instead of --prefix. This is the saner priority setting IMHO.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)