Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scdoc: fix cross compilation by setting HOST_SCDOC #202153

Merged
merged 1 commit into from
Nov 26, 2022
Merged

scdoc: fix cross compilation by setting HOST_SCDOC #202153

merged 1 commit into from
Nov 26, 2022

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Nov 21, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • riscv64-linux (cross)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Nov 21, 2022
@ofborg ofborg bot requested a review from primeos November 21, 2022 07:46
@symphorien symphorien merged commit d30627c into NixOS:master Nov 26, 2022
@NickCao NickCao deleted the scdoc-cross branch November 27, 2022 00:43
@primeos
Copy link
Member

primeos commented Nov 27, 2022

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickCao @primeos @symphorien