Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/signald: automatically migrate db #202923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 25, 2022

Description of changes

Run --migrate-data on every start, so that the database migrations don’t need to be run manually.
I’ve been running this on my server for a while.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Flakebi
Copy link
Member Author

Flakebi commented Jan 4, 2023

Ups, didn’t want to delete the branch

@Flakebi Flakebi reopened this Jan 4, 2023
@onny
Copy link
Contributor

onny commented May 31, 2023

Thank you for this idea :) Is this safe to use? Why doesn't signald does this by itself?

@Flakebi
Copy link
Member Author

Flakebi commented Jun 1, 2023

Is this safe to use?

Yes.

Why doesn't signald does this by itself?

No idea. It should be quite easy to run migrations in code but for a reason I don’t understand, some applications don’t do this.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants