Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clamav: Fixed typo preventing clamd service from starting #20304

Closed
wants to merge 1 commit into from
Closed

clamav: Fixed typo preventing clamd service from starting #20304

wants to merge 1 commit into from

Conversation

spacekitteh
Copy link
Contributor

@spacekitteh spacekitteh commented Nov 10, 2016 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@spacekitteh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mstrm, @jcbrand and @edolstra to be potential reviewers.

@fpletz
Copy link
Member

fpletz commented Nov 10, 2016

sbin should be a symlink to bin. What error are you observing?

@spacekitteh
Copy link
Contributor Author

It gives "command not found".

On Thu, 10 Nov 2016 at 15:38 Franz Pletz notifications@github.com wrote:

sbin should be a symlink to bin. What error are you observing?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20304 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB2crAVCbKV-l7UeFR2FLAUvZCGJYvlZks5q8q2_gaJpZM4KuRO0
.

@fpletz
Copy link
Member

fpletz commented Nov 11, 2016

Ok, I can confirm this behaviour on master. The regular clamav store path does have sbin as a symlink, though.

@grahamc
Copy link
Member

grahamc commented Nov 12, 2016

Perhaps the error is coming from the override somehow?

@fpletz fpletz closed this in 02e9c88 Nov 15, 2016
@fpletz
Copy link
Member

fpletz commented Nov 15, 2016 •
edited

Fixed the underlying issue. The fixupPhase was overridden if a freshclam config was given. In the fixupPhase the binaries are moved from sbin to bin and the symlink sbin -> bin is created.

bjornfor pushed a commit that referenced this pull request Jan 15, 2017
@fpletz @bjornfor
clamav: don't bundle freshclam config with package
3daf9cf 
Building clamav is expensive due to the bundled llvm.

Closes #20304.

(cherry picked from commit 02e9c88)
blajos pushed a commit to blajos/nixpkgs that referenced this pull request Jan 23, 2017
@fpletz
clamav: don't bundle freshclam config with package
6b8a528 
Building clamav is expensive due to the bundled llvm.

Closes NixOS#20304.

(cherry picked from commit 02e9c88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spacekitteh @mention-bot @fpletz @grahamc