Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2geometry: 0.9.0 → 0.10.0, enable on darwin #203123

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Nov 26, 2022

Description of changes

Changelog

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Nov 27, 2022

@ofborg build pure-maps

Fails for me on aarch64-linux

@sikmir
Copy link
Member Author

sikmir commented Nov 27, 2022

Cross compilation for aarch64-linux works for me.

@risicle
Copy link
Contributor

risicle commented Nov 27, 2022

The ofborg build for pure-maps fails even for x86_64 linux.

@sikmir
Copy link
Member Author

sikmir commented Nov 28, 2022

Result of nixpkgs-review pr 203123 run on x86_64-linux 1

1 package failed to build:
  • pure-maps
1 package built:
  • s2geometry
error: builder for '/nix/store/qyphjxppjiz4bkg5vz77dzkvnx9ndn29-pure-maps-3.1.1.drv' failed with exit code 2;
       last 10 log lines:
       >                  from /build/source/build/src/pure-maps_autogen/EWIEGA46WW/moc_locationmodel.cpp:10,
       >                  from /build/source/build/src/pure-maps_autogen/mocs_compilation.cpp:8:
       > /nix/store/hbwrbpj61kpmcx2cnprw4r2kxk7x4nbf-s2geometry-0.10.0/include/s2/s2point.h:21:10: fatal error: absl/hash/hash.h: No such file or directory
       >    21 | #include "absl/hash/hash.h"
       >       |          ^~~~~~~~~~~~~~~~~~
       > compilation terminated.

@wegank wegank marked this pull request as draft February 2, 2023 05:38
Copy link
Member

@Thra11 Thra11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on darwin, but if it builds on darwin that's a step forward.
Otherwise, I think you just need to bump the abesil-cpp version and then this will be good to go!

I was mistaken. There's still the issue with pure-maps not finding the abseil-cpp headers when inlcuding s2geometry's headers.

@Thra11
Copy link
Member

Thra11 commented May 14, 2023

@ofborg build pure-maps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants