Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mythtv: 31.0 -> 32.0 #203145

Merged
merged 1 commit into from
Nov 27, 2022
Merged

mythtv: 31.0 -> 32.0 #203145

merged 1 commit into from
Nov 27, 2022

Conversation

lilyinstarlight
Copy link
Member

@lilyinstarlight lilyinstarlight commented Nov 26, 2022

Description of changes

MythTV version bump, drawing from #197930 and K900's patch

I do not actually use this software myself and only care as it relates to dropping old Qt5 versions. I only confirmed that it builds (x86_64-linux and aarch64-linux), so if someone who actually uses this software could test it that would be very helpful

Related to dropping Qt 5.14: #201765

cc: @acarrico @zero-one01 @K900

Supersedes and closes #197930
Closes #190082

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.
nixpkgs-review

Result of nixpkgs-review pr 203145 run on x86_64-linux 1

1 package built:
  • mythtv

Result of nixpkgs-review pr 203145 run on aarch64-linux 1

1 package built:
  • mythtv

Co-authored-by: zero_one <zero_one_01@outlook.de>
Co-authored-by: Anthony Carrico <acarrico@memebeam.org>
Co-authored-by: K900 <me@0upti.me>
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, it... starts, at least. Can't really test much more.

@acarrico
Copy link
Contributor

It works fine on x86_64-linux.

@K900 K900 merged commit 1a7fdc7 into NixOS:master Nov 27, 2022
@lilyinstarlight lilyinstarlight deleted the pkg/mythtv-32.0 branch November 27, 2022 14:31
Comment on lines +10 to +12
+# if [ $target_os = "linux" ] ; then
+# . /etc/os-release
+# fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be removed instead of commented out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MythTV: 31.0 -> 32.0
4 participants