python311Packages.cchardet: fix for python 3.11 #203204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .cpp file released with this package to PyPI was built using an older version of Cython that is incompatible with Python 3.11. This package is not actively maintained, so it's unclear when the fix for this will be merged and released. In the meantime, we can include a newer version of Cython locally, which will be used instead to regenerate the .cpp file.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1502 |
|
Maybe we should keep that even after the change is merged to make sure the files are always up to date unless it creates more maintenance work than it fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .cpp file released with this package to PyPI was built using an older version of Cython that is incompatible with Python 3.11. This package is not actively maintained, so it's unclear when the fix for this will be merged and released.
In the meantime, we can include a newer version of Cython locally, which will be used instead to regenerate the .cpp file.
Related: PyYoshi/cChardet#81, PyYoshi/cChardet#77, and PyYoshi/cChardet#78
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes