Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams-for-linux: init at 1.0.45 #203796

Closed
wants to merge 4 commits into from

Conversation

aacebedo
Copy link
Contributor

Description of changes

This tool can replace current native client which is rumoured to be phased out this month.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/698

aacebedo and others added 3 commits December 1, 2022 20:56
…x/default.nix

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
…x/default.nix

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@aacebedo
Copy link
Contributor Author

aacebedo commented Dec 1, 2022

Modifications done. Also added libappindicator that was missing.
When I got approval I'll squash the commit

@bobby285271
Copy link
Member

bobby285271 commented Dec 11, 2022

Thanks for the PR, but this is now added in #205026 (which builds this from source), feel free to re-open (and resolve the merge conflicts) if I am wrong.

@aacebedo aacebedo mentioned this pull request Dec 12, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants