shairport-sync: 3.3.9 -> 4.1.1 #203869
Merged
shairport-sync: 3.3.9 -> 4.1.1 #203869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanisaacs
force-pushed
the
shairport-sync-update
branch
from
0494a80
to
eb7363d
Compare
|
all fixed @SuperSandro2000 |
|
shairport-sync 4.1.1 is out -- I was just about to make a PR myself until I saw this. Is the latest sha if you want to update |
seryl
reviewed
Dec 30, 2022
jordanisaacs
force-pushed
the
shairport-sync-update
branch
2 times, most recently
from
ebba8dd
to
5882a15
Compare
jordanisaacs
changed the title
jordanisaacs
force-pushed
the
shairport-sync-update
branch
from
5882a15
to
813469b
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1733 |
jordanisaacs
force-pushed
the
shairport-sync-update
branch
from
813469b
to
9722f82
Compare
|
If this could be merged that would be great! I'm looking to try the new pipewire backend. |
|
If you mention it on the discourse for already reviewed might help it get merged. Been through a few reviews already so should be good ot go (also you can apply the patch yourself if you want). @hexagonal-sun |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update shairport-sync from 3.9 to 4.1.1. Additionally it is now formatted and enables configuration using function arguments. Differences from the previous version are enabling jack and pipewire backends by default. Airplay 2 is disabled by default to not break the nixos module as running it is much more complicated (requires nqptp). Added myself as a maintainer.
Closes #198387
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesBuilt each
enableXXXoption successfully and ran the--helpcommand. Ran nixpkgs default build successfully with the pipewire backend. I have not tested the existing nixos module.Pinging @LnL7