Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcb: init at 1.2 #203916

Merged
merged 1 commit into from
Dec 4, 2022
Merged

tcb: init at 1.2 #203916

merged 1 commit into from
Dec 4, 2022

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 1, 2022

Description of changes

The tcb package contains core components of implementing alternative password shadowing scheme on Owl.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin marked this pull request as draft December 1, 2022 13:10
@Izorkin Izorkin force-pushed the init-tcb branch 5 times, most recently from ae9b78b to 4662898 Compare December 1, 2022 17:29
@Izorkin Izorkin marked this pull request as ready for review December 1, 2022 17:33
@Izorkin Izorkin force-pushed the init-tcb branch 2 times, most recently from 6f66e35 to 2af64c5 Compare December 2, 2022 10:39
muscaln
muscaln suggested changes Dec 3, 2022
View reviewed changes
pkgs/tools/security/tcb/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/tcb/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/tcb/default.nix Outdated Show resolved Hide resolved
@Izorkin Izorkin requested a review from muscaln December 3, 2022 17:00
@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 4, 2022

Changed the download source to github. There in latest changes added support for pkg-config.

@AndersonTorres AndersonTorres merged commit 707d2e9 into NixOS:master Dec 4, 2022
@solardiz solardiz mentioned this pull request Dec 4, 2022
Open
@Izorkin Izorkin deleted the init-tcb branch January 16, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres requested changes

@solardiz solardiz solardiz left review comments

@muscaln muscaln Awaiting requested review from muscaln

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @AndersonTorres @solardiz @muscaln