Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.11] subsurface: 5.0.2 -> 5.0.10 and unbreak build #204167

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[22.11] subsurface: 5.0.2 -> 5.0.10 and unbreak build #204167

merged 1 commit into from
Dec 19, 2022

Conversation

schmittlauch
Copy link
Member

Description of changes

backport of #202145

Necessary in 22.11, as it removes the dependency on the broken qtwebkit (#201028) and replaces it by qtwebengine.

The build result of this PR could even be substituted from the binary cache, indicating it is equivalent with the state of master at some point.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@peterhoeg @schmittlauch
subsurface: 5.0.2 -> 5.0.10 (NixOS#202145)
db7a359 
* subsurface: 5.0.2 -> 5.0.10

* override version detection

(cherry picked from commit 689f590)
@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build subsurface

@ofborg ofborg bot requested review from mguentner and adisbladis December 2, 2022 20:00
@vcunat vcunat merged commit 2db4c60 into NixOS:release-22.11 Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguentner mguentner Awaiting requested review from mguentner

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @vcunat @peterhoeg