kaiscr: init at unstable-2020-10-21 #204375
Open
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azahi
requested changes
Dec 4, 2022
Comment on lines
+42
to
+51
| checkPhase = '' | ||
| runHook preCheck | ||
| $out/bin/kaiscr -h | ||
| runHook postCheck | ||
| ''; |
There was a problem hiding this comment.
Weird thing to do inside a check phase. Can we use testers.testVersion instead?
There was a problem hiding this comment.
There's no --version and I think it'd be misleading to testVersion on the --help when it'd be doing the same thing as this. I'll make it --help though.
|
I forgot to test |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Built on the second try excluding the hash fetch (:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes