Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcode: add missing versions #204493

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Conversation

reckenrode
Copy link
Contributor

Description of changes

Add the missing versions of Xcode up through 14.1. This PR also updates the hashes of the old versions to SRI format for consistency. The following script was used to do that. Xcode 14.1 was tested successfully building a Package.swift-based project.

while read hash; do
    oldHash=$(sed -E 's/ *xcode_[^=]*= requireXcode "[0-9][^"]*" "([^"]*)";/\1/' <(echo "$hash"))
    newHash=$(nix hash to-sri --type sha256 $oldHash)
    echo $hash | sed -E 's|( *xcode_[^=]*= requireXcode "[0-9][^"]*" ")([^"]*)(";)|\1'$newHash'\3|'
done < <(tail -n +44 pkgs/os-specific/darwin/xcode/default.nix | head -n 25)
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1762

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need all of those?

Also please rebase.

@reckenrode
Copy link
Contributor Author

Do we really need all of those?

The user has to add Xcode.app to the store manually, so the cost of including the extra versions seems negligible.

Also please rebase.

Done.

@louwers
Copy link

louwers commented Feb 12, 2023

Xcode 14.2 is out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants