Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raspberrypi-eeprom: 2022.04.26-138a1 -> 2022.12.07-138a1 #204682

Merged
merged 1 commit into from
Dec 20, 2022
Merged

raspberrypi-eeprom: 2022.04.26-138a1 -> 2022.12.07-138a1 #204682

merged 1 commit into from
Dec 20, 2022

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Dec 5, 2022 •
edited

Description of changes

https://github.com/raspberrypi/rpi-eeprom/releases/tag/v2022.12.07-138a1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dasJ December 5, 2022 21:13
@golddranks
Copy link
Contributor

There is already a new fix release: https://github.com/raspberrypi/rpi-eeprom/blob/master/firmware/release-notes.md#2022-12-07---fix-sd-voltage-reset-on-pi4-r11-defaultstablebeta

@Luflosi Luflosi marked this pull request as draft December 8, 2022 08:25
@Luflosi Luflosi changed the title raspberrypi-eeprom: 2022.04.26-138a1 -> 2022.11.25-138a1 raspberrypi-eeprom: 2022.04.26-138a1 -> 2022.12.07-138a1 Dec 9, 2022
@Luflosi Luflosi marked this pull request as ready for review December 9, 2022 10:14
golddranks
golddranks approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@golddranks golddranks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/747

@SuperSandro2000 SuperSandro2000 merged commit 9eec887 into NixOS:master Dec 20, 2022
@Luflosi Luflosi deleted the update/raspberrypi-eeprom branch December 20, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golddranks golddranks golddranks approved these changes

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Luflosi @golddranks @nixos-discourse @SuperSandro2000