iay: init at 0.4.0 #204936
iay: init at 0.4.0 #204936
Conversation
iay is a tool to configure a shell prompt. It supports bash and zsh. Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| homepage = "https://github.com/aaqaishtyaq/iay"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ omasanori ]; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
| platforms = platforms.unix; |
that is the default for buildRustPackage, we don't want to repeat it
There was a problem hiding this comment.
OK, I will remove that line. Thanks!
| pname = "iay"; | ||
| version = "0.4.0"; | ||
|
|
||
| src = fetchCrate { |
There was a problem hiding this comment.
There is a cargo lock in the repo https://github.com/aaqaishtyaq/iay/blob/trunk/Cargo.lock . Why not fetch that?
There was a problem hiding this comment.
Thank you for reviewing!
So, should fetchCrate be avoided if the repository has Cargo.lock? This is the first time I package a Rust program and https://nixos.org/manual/nixpkgs/stable/#rust does not mention whether fetchCrate is discouraged or not. Would you point out guidelines, if you are aware of any?
Description of changes
This adds iay, an utility program for shell prompt configuration.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes