-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logseq: Fix publishing graph #205057
logseq: Fix publishing graph #205057
Conversation
c2db74c
to
108c063
Compare
Could you review this change please @weihua-lu? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1681 |
ed76400
to
39e9d6c
Compare
Please rebase |
Related to logseq/logseq#6880 Logseq publishes graphs by copying application assets into a folder and then the graph files (+/- some operations). In a normal linux distribution the application asset directories are rw but only by root. On nix, the directories are read-only, which leads to the copied directories also being ro and logseq failing to copy the graph files into the target. A fix from the logseq team isn't forthcoming (yet?), so we circumvent the entire ro issue by using run-appimage, which extracts the appimage into a user-writeable directory.
39e9d6c
to
7db6808
Compare
Rebased @SuperSandro2000 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1772 |
Thanks for merging @SuperSandro2000 🙏 |
It seems that this change broke Logseq Sync:
Logseq version is 0.8.16 (b5b1a46) And if I roll back to when it wasn't an appimage the version and commit are the same and everything works (except publishing I guess), although it still shows this one error line in logs
Soo creating native nodejs buffers broke or something?. |
Looks like Logseq Sync is a paid and limited feature. Unfortunately, I have no way of testing this.
FYI they both use AppImage, the major difference is that prior to my PR the contents were extracted into the /nix/store (a read-only location) and now it's run with appimage-run which extracts the AppImage to a user's XDG folder (I think its the cache folder --> /home/user/.cache/...). Maybe appimage-run misses a step that mkDerivation does, I don't know 🫥
Have you tried opening the developer console? (Ctrl+shift+I) Maybe there's more information there?
|
I'm not exactly sure what happened, but once again I've switched nixos to latest unstable, and now it asked me to do a full relogin and now it seems to work. |
Description of changes
Related to logseq/logseq#6880
Logseq publishes graphs by copying application assets into a folder and then the graph files (+/- some operations). In a normal linux distribution the application asset directories are rw but only by root. On nix, the directories are read-only, which leads to the copied directories also being ro and logseq failing
to copy the graph files into the target.
A fix from the logseq team isn't forthcoming (yet?), so we circumvent the entire ro issue by using
run-appimage, which extracts the appimage into a user-writeable directory.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesFixes #199035