Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibc: 2.35-163 -> 2.35-224 #205133

Merged
merged 2 commits into from
Dec 9, 2022
Merged

glibc: 2.35-163 -> 2.35-224 #205133

merged 2 commits into from
Dec 9, 2022

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Dec 8, 2022

Fixes #204721

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
glibc: 2.35-163 -> 2.35-224
ec7567b
@vcunat
glibc: revert one patch from those added in parent commit
5dffcba 
For now.  It causes issues in python3Packages.twisted testsuite,
so maybe it's buggy.  The tests might be buggy instead, but so far
we've had no report of the issues that are to be fixed by the patch.
NixOS#201805 (comment)
This was referenced Dec 8, 2022
Closed
Closed
@vcunat vcunat linked an issue Dec 8, 2022 that may be closed by this pull request
installer iso not booting on some cpus due to glibc bug #204721
Closed
@ofborg ofborg bot requested review from edolstra and Ma27 December 8, 2022 15:04
trofi
trofi approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Built my system successfully (had to roll back unrelated python changes)

@vcunat vcunat merged commit f1996e3 into NixOS:staging Dec 9, 2022
@vcunat vcunat deleted the p/glibc-patches branch December 9, 2022 09:43
@github-actions github-actions bot mentioned this pull request Dec 9, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Successfully created backport PR #205272 for staging-22.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

installer iso not booting on some cpus due to glibc bug
3 participants
@vcunat @trofi @SuperSandro2000