Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

river-tag-overlay: init at 1.0.0 #205513

Merged
merged 2 commits into from
Jan 24, 2023
Merged

river-tag-overlay: init at 1.0.0 #205513

merged 2 commits into from
Jan 24, 2023

Conversation

edrex
Copy link
Contributor

@edrex edrex commented Dec 10, 2022

Things done
  • Built on platform(s)
    • x86_64-linux
  • Tested, as applicable:
    • no pkg tests
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@edrex edrex force-pushed the river-tag-overlay branch 2 times, most recently from 4f99a04 to 6efde4a Compare December 11, 2022 19:33
@edrex edrex changed the title init river-tag-overlay at 1.0.0 river-tag-overlay: init at 1.0.0 Dec 11, 2022
@edrex edrex requested a review from rodrgz December 11, 2022 19:37
rodrgz
rodrgz approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@rodrgz rodrgz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edrex
Copy link
Contributor Author

edrex commented Dec 14, 2022

There seems to be a build error on aarch64-linux, need to investigate with upstream.

urandom2
urandom2 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@urandom2 urandom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ofborg is happy, so am I

pkgs/applications/misc/river-tag-overlay/default.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/748

@edrex
Copy link
Contributor Author

edrex commented Dec 20, 2022

is it ok to merge a package that doesn't build on aarch64-linux? It should eventually be fixed upstream.

@urandom2
Copy link
Contributor

yes, but we should flag it as broken by adding meta.broken = stdenv.isAarch64;

@edrex
Copy link
Contributor Author

edrex commented Jan 19, 2023

ok, marked as broken on Aarch64. I think this is ready. Thanks for all the help with review @urandom2

@thiagokokada thiagokokada merged commit 464de79 into NixOS:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@thiagokokada thiagokokada thiagokokada approved these changes

@urandom2 urandom2 urandom2 approved these changes

@rodrgz rodrgz rodrgz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@edrex @nixos-discourse @urandom2 @thiagokokada @SuperSandro2000 @rodrgz