mopidy-gmusic: 1.0.0 -> 2.0.0 #20675
Conversation
|
@carlsverre, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jgillich and @FRidh to be potential reviewers. |
| @@ -0,0 +1,18 @@ | |||
| { stdenv, fetchurl, python, buildPythonPackage, gmp }: | |||
|
|
|||
| buildPythonPackage rec { | |||
There was a problem hiding this comment.
I can move this into the top level python packages file - I put it here to match pycrypto since pycryptodome is a fork of pycrypto. Open to thoughts on this.
There was a problem hiding this comment.
no, it's good to leave it here, since python-packages.nix is getting way too big and having a function is more flexible as well.
|
Note: this is based on channels/nixos-unstable which I am running on my machine. |
|
Anyone know why digikam was built in the travis-ci build? I don't see how my changes affected it. Seems like nox tried to rebuild everything that depended on any python package or something? Not sure whats going on here. |
|
@anderspapitto maybe you might know? |
|
Each package you modify needs to be in a commit of its own. |
carlsverre
force-pushed
the
update/mopidy-gmusic
branch
from
4d4e22f
to
97b35a0
Compare
|
@FRidh like that? |
|
yep, thanks |
Motivation for this change
Gmusic api changed - 2.x version is required to connect to google music.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)