geph: init at 4.7.8 #206817
geph: init at 4.7.8 #206817
Conversation
penalty1083
force-pushed
the
geph
branch
2 times, most recently
from
d69fcf9
to
61083f0
Compare
| rm package-lock.json | ||
| ln -s ${./package-lock.json} ./package-lock.json |
There was a problem hiding this comment.
Why do we need to delete the file?
There was a problem hiding this comment.
I generated a lock file because fetch-npm-deps doesn't work with the upstream lock file. It seems fetch-npm-deps ignores deps without integrity.
We need to generate a correct lock file.
There was a problem hiding this comment.
It seems the problem is fixed upstream so this is not needed anymore.
There was a problem hiding this comment.
They removed the lock file in 4.7.8 so I have to generate one again.
|
Updated to 4.7.5. |
|
Updated to 4.7.7. @SuperSandro2000 Could you please review this again? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
|
||
| meta = geph-meta // { | ||
| mainProgram = "gephgui-wry"; | ||
| license = with lib.licenses; [ unfree ]; |
There was a problem hiding this comment.
Can we be a bit more specific which unfree license or is it custom?
There was a problem hiding this comment.
There is no license in the repo. 🤷
|
Thanks for merging! |
Description of changes
Closes #169326
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesPing author and reviewers in #169326 @jslll135 @NickCao @SuperSandro2000 @alienzj