postgresql: fix build on darwin #20684
Conversation
|
@basvandijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vcunat and @BFrog to be potential reviewers. |
|
I thought this was already fixed. |
| '' | ||
| # initdb needs access to "locale" command from glibc. | ||
| wrapProgram $out/bin/initdb --prefix PATH ":" ${glibc.bin}/bin | ||
| wrapProgram $out/bin/initdb --prefix PATH ":" ${pkgs.glibc.bin}/bin |
There was a problem hiding this comment.
Is pkgs.glibc neccesary, I think it's fine to use glibc directly as long as it's not evaluated on darwin.
basvandijk
force-pushed
the
fix-postgresql-osx
branch
from
3116367
to
1f95524
Compare
|
@LnL7 thanks for the tip. I pushed a correction. |
|
@LnL7 thanks for the merge. Could you also cherry pick this on |
|
I'm not sure if changes like this are usually backported to nixos release branches. /cc @copumpkin |
|
@LnL7 note that @edolstra cherry picked my postgresql-9.6 patch (which introduced the darwin error) on |
This fixes the build of postgresql on OS X as reported by @jwiegley.
Tested on both NixOS en OS X.
@edolstra this also needs to be cherry picked on
release-16.09.