Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releaseTools.debBuild: split checkinstall into separate phase #20767

Merged
merged 1 commit into from Dec 30, 2016

Conversation

abbradar
Copy link
Member

Motivation for this change

This is needed for my incoming pull request to Nix that improves situation with Debian packages.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@abbradar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @rbvermaa and @Profpatsch to be potential reviewers.

@abbradar
Copy link
Member Author

This breaks compatibility with Nix's release.nix because postInstall now runs after make install and not after a resulting Debian package is installed (which seems more "right" to me). However, Nix's corresponging PR is still not merged so Nix .deb packages are now broken. We may want a revert -- not sure how to proceed.

@7c6f434c
Copy link
Member

Hm. Didn't understand there is a circular dependency between these PRs… The description looked like a single-direction dependency. And merging something into Nix will probably take some time…

I guess then reverting for now could be a reasonable thing to do…

@abbradar
Copy link
Member Author

Yep, I did a bad job describing the change (also didn't mention the incompatibility). I'll revert it, sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants