Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the /nix/store writable under netboot images #20795

Merged
merged 1 commit into from Nov 29, 2016

Conversation

cleverca22
Copy link
Contributor

Motivation for this change

prior to this change, the netboot images mounted /nix/store read-only, and the nix-store --check-validity call in nixos-install tries to create /nix/store/.links on the host, causing it to fail

the mount config was simply copied from the iso-image.nix module, and tweaked to find the squashfs in the initrd

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@cleverca22, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nshalman to be a potential reviewer.

@nshalman
Copy link
Member

Certainly looks more elegant than my original code. :)

@domenkozar domenkozar merged commit 69e0740 into NixOS:master Nov 29, 2016
@cleverca22 cleverca22 deleted the netboot branch November 29, 2016 14:49
@dasJ
Copy link
Member

dasJ commented Feb 2, 2020

@cleverca22 Seems like some necrobumping commenting here…
Is there any particualar reason you chose a fuse filesystem for overlaying? Seems like a slow solution compared to e.g. overlayfs

@cleverca22
Copy link
Contributor Author

dont remember exactly, but i was probably copying another similar boot process in nixos, that already used fuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants