runescape-launcher: fix clicking web links in the launcher #208644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/runescape_xdg
branch
from
a2ab4dd
to
409eff0
Compare
GRBurst
approved these changes
Jan 2, 2023
The launcher uses the 'xdg-open' command to open http URIs in the browser. Without this installed, clicking links in the launcher will result in nothing happening.
anoadragon453
force-pushed
the
anoa/runescape_xdg
branch
from
409eff0
to
ca66dbc
Compare
|
I've rebased this PR on latest |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes the behaviour of clicking web links in the runescape launcher. The launcher attempts to call
xdg-open <url>when clicking a link in the UI, which will fail ifxdg-openis not installed. This PR installsxdg-openinto the environment, and clicking links now works.This PR includes a commit that organises the list of installed packages, so it can be difficult to review all changes. The commit to review that installs
xdg-openis 409eff0.Note: The build of this derivation will fail until #208642 is merged.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes