New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binaryen: 109 -> 111 #209122
binaryen: 109 -> 111 #209122
Conversation
This PR will not work unless additional work is done to backport the binaryen bumps to emscripten. @RaitoBezarius I'll try that out a little and see if it can either go here or possibly sneak in to #206005 (unless that's getting merged in the near future!) |
Result of 6 packages marked as broken and skipped:
1 package failed to build:
7 packages built:
|
Result of 2 packages failed to build:
29 packages built:
|
@RaitoBezarius looks like even old emscripten works with the updated binaryen, so this shouldn't conflict with the emscripten PR! |
Do we still want to proceed with this one @willcohen ? (some merge conflicts) |
Yes — will rebase in the next day or two! |
@RaitoBezarius should be ready to go! |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1728 |
Reviewing on my side on x86_64-linux and aarch64-linux, if good, I will merge it. |
Result of 2 packages failed to build:
29 packages built:
|
Result of 1 package marked as broken and skipped:
17 packages built:
|
Thank you! |
Description of changes
In an attempt to backport WebAssembly/binaryen#5378 and WebAssembly/binaryen#5391, upstream has diverged enough from what's in nixpkgs that a lot of manual merge conflict resolutions would be necessary, which requires rebuilding a lot of the wasm2js test case outputs. This might grow to be frustrating as time goes on.
As noted by #206005, emscripten is blocked by #194634, but this PR bumps binaryen forward from 109 to 111 (plus upstream backports) separately.
@RaitoBezarius
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes