-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ocaml packages fix build on darwin #209132
Ocaml packages fix build on darwin #209132
Conversation
@@ -1,4 +1,4 @@ | |||
{ lib, buildDunePackage, fetchFromGitHub, dune-configurator, pkg-config, glib, gst_all_1 }: | |||
{ lib, stdenv, buildDunePackage, fetchFromGitHub, dune-configurator, AppKit, Foundation, pkg-config, glib, gst_all_1 }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does I profit of this PR to split deps on each line and sort them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer it to be in a separate PR whose name starts with treewide.
@ofborg build ocamlPackages.ocaml_libvirt ocamlPackages.labltk ocamlPackages.gstreamer ocamlPackages.ffmpeg-avutil ocamlPackages.bjack ocamlPackages.ffmpeg-avcodec ocamlPackages.ffmpeg-avfilter ocamlPackages.ffmpeg-swscale ocamlPackages.ffmpeg-av ocamlPackages.ffmpeg-avdevice ocamlPackages.ffmpeg-swresample |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Description of changes
While testing #197367 I saw that many other package was broken with the same kind of error so I did a pass to fix the same error in multiple packages.
build log before this PR:
Things done
copied from what is done with cairo2
For reviewer:
(might be quicker than nixpkgs-review)
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes