jid: init at 0.6.1 #20923
Merged
jid: init at 0.6.1 #20923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh-oh, made a mistake in |
|
Okay, builds now. |
|
Waiting for something? |
|
@vcunat I’d always like someone else to skim the code, maybe I forgot something. And since I already have it in my local repos it’s normally not time-critical. |
|
@Profpatsch, I see. After a simple read, I can't see anything to improve, except that you probably want to set |
|
@vcunat Doesn’t that default to all anyway? |
|
Heh, yes. It seems very strange for |
vcunat
added a commit
that referenced
this pull request
Dec 14, 2016
platforms.all makes no sense as go.meta.platforms is smaller. Discussion: #20923 (comment)
|
Well, I corrected that now e065861 |
|
Ah, ok. Yay for sane defaults! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./result/bin/)Nice simple interactive json filter.