openlens: init at 6.4.5

[benwbooth]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[wegank]

I just saw the last commit, and I wonder what is the point of going to an alpha version, when 6.3.0 was released three weeks ago...

[benwbooth]

6.3.0 is a controversial release that removes a lot of features. The 6.4.0-alpha.2 brings back some of the removed features. See lensapp/lens#6823

[wegank]

Ok, thanks for the information!

[benwbooth]

I had to revert to version 6.2.5 since that is the most recent non-broken version before 6.3.0.

[SebTM]

Thanks for the PR, I tried it and had some issues (I suspect Wayland?) with the following error-message:

(open-lens:2): Gdk-ERROR **: 19:43:24.545: The program 'open-lens' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAccess (attempt to access private resource denied)'.
  (Details: serial 251 error_code 10 request_code 130 (MIT-SHM) minor_code 1)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

With some help and context from #104412, #109466 I found a solution: unshareIpc = false inside appimageTools.wrapType2-block. Exporting QT_X11_NO_MITSHM=1 before launching openlens from console didn't helped, unsharePid seems to be not necessary for me.

[benwbooth]

@SebTM are you using X11 or wayland? I'm using wayland and haven't encountered this error.

[SebTM]

I'm using Wayland, with sway - I'm on unstable e1e1b192c1a5aab2960bf0a0bd53a2e8124fa18e

[SebTM]

Hey, thanks for following up - shortly after there was also v6.4.3 released. If you like to, you can add me to maintainer as well. Please update the title and check-boxes when done accordingly and I would think we are good-2-go ✌🏻

[benwbooth]

@SebTM I updated to 6.4.3 and added you as a maintainer. Thanks!

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/858

[SebTM]

@benwbooth Can't merge myself, so mentioned it as reviewed in a discourse thread - so nothing wrong just waiting for some attention ✌🏻

[SebTM]

I guess you should squash the commits together that it's only one or if possible check that it's enabled on pr-side to do so on merge ✌️

[benwbooth]

@SebTM I squashed the commits. Thanks!